Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 (slope) only enable dismiss by click after interaction / TAS-508 #3660

Merged
merged 1 commit into from
May 28, 2024

Conversation

sophiamersmann
Copy link
Member

@sophiamersmann sophiamersmann commented May 28, 2024

If a slope chart has a selection by default, then don't dismiss the default selection when the user clicks anywhere in the grapher frame. Only allow dismissing the current selection after the user has interacted with the chart.

Example: https://ourworldindata.org/change-in-female-height-slope

Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @sophiamersmann and the rest of your teammates on Graphite Graphite

@sophiamersmann sophiamersmann changed the title 🐛 (slope) only enable dismiss by click after interaction 🐛 (slope) only enable dismiss by click after interaction / TAS-508 May 28, 2024
Copy link

@sophiamersmann sophiamersmann marked this pull request as ready for review May 28, 2024 15:55
@owidbot
Copy link
Contributor

owidbot commented May 28, 2024

Quick links (staging server):

Site Admin Wizard

Login: ssh owid@staging-site-slope-dismiss

SVG tester:

Number of differences (default views): 0
Number of differences (all views): 0

Edited: 2024-05-28 16:04:44 UTC
Execution time: 1.27 seconds

@sophiamersmann sophiamersmann merged commit bd800cf into master May 28, 2024
26 checks passed
@sophiamersmann sophiamersmann deleted the slope-dismiss branch May 28, 2024 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants