Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ (grapher) left-align external facet legend #3631

Merged
merged 1 commit into from
May 24, 2024

Conversation

sophiamersmann
Copy link
Member

@sophiamersmann sophiamersmann commented May 22, 2024

The external facet legend is the only one that is center-aligned. Left-align for consistency.

Copy link
Member Author

sophiamersmann commented May 22, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @sophiamersmann and the rest of your teammates on Graphite Graphite

@owidbot
Copy link
Contributor

owidbot commented May 22, 2024

Quick links (staging server):

Site Admin Wizard

Login: ssh owid@staging-site-facet-legend-left-align

SVG tester:

Number of differences (default views): 83 (25d40e)
Number of differences (all views): 452 (e1ea5d)

Edited: 2024-05-24 06:17:01 UTC
Execution time: 1.18 seconds

@sophiamersmann sophiamersmann force-pushed the facet-legend-left-align branch from 4c56581 to 5fd3b0f Compare May 22, 2024 11:57
@sophiamersmann sophiamersmann force-pushed the facet-legend-left-align branch from 5fd3b0f to 749cfa9 Compare May 22, 2024 11:59
@sophiamersmann sophiamersmann force-pushed the facet-legend-left-align branch from 749cfa9 to 1553134 Compare May 22, 2024 12:31
@sophiamersmann sophiamersmann force-pushed the facet-legend-left-align branch from 1553134 to b051fba Compare May 22, 2024 12:39
@sophiamersmann sophiamersmann marked this pull request as ready for review May 22, 2024 14:55
@sophiamersmann sophiamersmann force-pushed the facet-legend-left-align branch from b051fba to bc697ef Compare May 23, 2024 16:57
@sophiamersmann sophiamersmann force-pushed the facet-legend-left-align branch from bc697ef to 1c8c782 Compare May 24, 2024 06:02
Copy link
Member Author

sophiamersmann commented May 24, 2024

Merge activity

Base automatically changed from facet-padding to master May 24, 2024 07:51
@sophiamersmann sophiamersmann force-pushed the facet-legend-left-align branch from 1c8c782 to dbe78cb Compare May 24, 2024 07:51
@sophiamersmann sophiamersmann merged commit 3bc1a35 into master May 24, 2024
10 of 15 checks passed
@sophiamersmann sophiamersmann deleted the facet-legend-left-align branch May 24, 2024 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants