-
-
Notifications
You must be signed in to change notification settings - Fork 229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ (stacked bar) move legend to the top on mobile #3629
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @sophiamersmann and the rest of your teammates on |
Quick links (staging server):
Login:
SVG tester:Number of differences (default views): 19 (a90d8f) ❌ Edited: 2024-06-10 11:25:39 UTC |
72de730
to
3114651
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! The only thing I could find is that with faceting (for example 2x2), this can make things worse at some screen widths.
If you want to look into that some more, feel free, but otherwise this is also fine.
I realize now that the faceting legend logic is different, as it is always placing the legend at the top.
4ac4b65
to
b7a54a5
Compare
3114651
to
e2a2fa1
Compare
Merge activity
|
b7a54a5
to
8a30d59
Compare
e2a2fa1
to
ce77a8b
Compare
ce77a8b
to
2457b47
Compare
Moves the legend of stacked bar charts to the top on mobile.
(SVG differences come from the previous PR)
If there is very little space (due to long text), then moving the legend to the top eats into the vertical space badly:
(Note that the legend overflows in the before version)