Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ (stacked bar) hide single-item legends #3622

Merged
merged 1 commit into from
Jun 10, 2024

Conversation

sophiamersmann
Copy link
Member

@sophiamersmann sophiamersmann commented May 21, 2024

Hide single-item legends for stacked bar charts. This is space-saving for mobile especially.

For stacked area charts with a "Change entity" button, the currently selected entity is shown in the title.

Before After
https://ourworldindata.org/grapher/ace-north-atlantic-hurricanes http://staging-site-stacked-bar-hide-legend/grapher/ace-north-atlantic-hurricanes
Screenshot 2024-05-21 at 16 37 08 Screenshot 2024-05-21 at 16 36 57
https://ourworldindata.org/grapher/tsunami-deaths http://staging-site-stacked-bar-hide-legend/grapher/tsunami-deaths
Screenshot 2024-05-22 at 10 49 45 Screenshot 2024-05-22 at 10 49 58

Copy link
Member Author

sophiamersmann commented May 21, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @sophiamersmann and the rest of your teammates on Graphite Graphite

@owidbot
Copy link
Contributor

owidbot commented May 21, 2024

Quick links (staging server):

Site Admin Wizard

Login: ssh owid@staging-site-stacked-bar-hide-legend

SVG tester:

Number of differences (default views): 19 (e68061) ❌
Number of differences (all views): 100 (fb6aa7) ❌

Edited: 2024-06-10 11:06:25 UTC
Execution time: 1.21 seconds

@sophiamersmann sophiamersmann force-pushed the stacked-bar-hide-legend branch 2 times, most recently from d24a48f to 9486ad6 Compare May 21, 2024 12:43
@sophiamersmann sophiamersmann marked this pull request as ready for review May 21, 2024 14:38
@sophiamersmann sophiamersmann requested review from marcelgerber and removed request for marcelgerber May 21, 2024 14:39
@sophiamersmann sophiamersmann marked this pull request as draft May 21, 2024 15:28
@sophiamersmann sophiamersmann force-pushed the stacked-bar-hide-legend branch 2 times, most recently from 80593e2 to 4ac4b65 Compare May 22, 2024 09:07
@sophiamersmann sophiamersmann marked this pull request as ready for review May 22, 2024 12:37
Copy link

Copy link
Member

@marcelgerber marcelgerber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@sophiamersmann sophiamersmann force-pushed the stacked-bar-hide-legend branch from 4ac4b65 to b7a54a5 Compare June 10, 2024 10:49
Copy link
Member Author

sophiamersmann commented Jun 10, 2024

Merge activity

@sophiamersmann sophiamersmann force-pushed the stacked-bar-hide-legend branch from b7a54a5 to 8a30d59 Compare June 10, 2024 11:45
@sophiamersmann sophiamersmann merged commit 23f14e3 into master Jun 10, 2024
12 of 13 checks passed
@sophiamersmann sophiamersmann deleted the stacked-bar-hide-legend branch June 10, 2024 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants