Fix deleted assets staying in Cloudflare cache #3518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rakyi
changed the title
|
This PR has had no activity within the last two weeks. It is considered stale and will be closed in 3 days if no further activity is detected. |
rakyi
force-pushed
the
fix-deleted-assets-in-cache
branch
from
64d7381 to
8aba47a
Compare
|
Quick links (staging server):
Login:
SVG tester:Number of differences (default views): 0 ✅ Edited: 2024-06-14 10:26:05 UTC |
When we delete a post it no longer gets baked and is thus not present in the next CF Pages deployment. However, assets can stay in the CF Pages cache for up to a week and we want them to be inaccessible right away, e.g. for job postings.
marcelgerber
approved these changes
Jun 17, 2024
rakyi
force-pushed
the
fix-deleted-assets-in-cache
branch
from
eebe6f6 to
314ad03
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we delete a post it no longer gets baked and is thus not present in the next CF Pages deployment. However, assets can stay in the CF Pages cache for up to a week and we want them to be inaccessible right away, e.g. for job postings.
I verified that this works both locally and on staging, including deployment to staging Pages.
Fixes #2896