Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix misplaced indicator's description field #3053

Merged
merged 2 commits into from
Jan 3, 2024

Conversation

pabloarosado
Copy link
Contributor

Fixes #3052

NOTE: I am not very familiar with this code and have not looked deeply into it, so there may be cases I haven't considered.

This PR:

  • Shows description next to the indicator's title, when descriptionShort does not exist but description does exist.
  • Removes indicator's description from the sources.

…and mistakenly showing as a source description
@sophiamersmann sophiamersmann force-pushed the fix-misplaced-indicator-description branch from fd3360c to 75dbf87 Compare January 3, 2024 10:18
Copy link
Member

@sophiamersmann sophiamersmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thank you!

@sophiamersmann sophiamersmann merged commit 58a4a34 into master Jan 3, 2024
13 checks passed
@sophiamersmann sophiamersmann deleted the fix-misplaced-indicator-description branch January 3, 2024 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Indicator's description is used as a source's description instead of an indicator's description
2 participants