From c28f0730dafa15aa96c216ff79edf57b08a505c4 Mon Sep 17 00:00:00 2001
From: Daniel Bachler <daniel@danielbachler.de>
Date: Sat, 27 Jan 2024 02:24:44 +0100
Subject: [PATCH] =?UTF-8?q?=F0=9F=94=A8=20make=20name=20on=20datasets=20ma?=
 =?UTF-8?q?ndatory?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

---
 ...706317870929-DatasetsFieldNameMandatory.ts | 19 +++++++++++++++++++
 .../types/src/dbTypes/Datasets.ts             |  2 +-
 2 files changed, 20 insertions(+), 1 deletion(-)
 create mode 100644 db/migration/1706317870929-DatasetsFieldNameMandatory.ts

diff --git a/db/migration/1706317870929-DatasetsFieldNameMandatory.ts b/db/migration/1706317870929-DatasetsFieldNameMandatory.ts
new file mode 100644
index 00000000000..b74487d6396
--- /dev/null
+++ b/db/migration/1706317870929-DatasetsFieldNameMandatory.ts
@@ -0,0 +1,19 @@
+import { MigrationInterface, QueryRunner } from "typeorm"
+
+export class DatasetsFieldNameMandatory1706317870929
+    implements MigrationInterface
+{
+    public async up(queryRunner: QueryRunner): Promise<void> {
+        // The name field is nullable in the DB schema but null is never used in the values in the DB,
+        // so it's better to make it mandatory in the DB schema.
+        await queryRunner.query(
+            `ALTER TABLE datasets MODIFY COLUMN name VARCHAR(512) NOT NULL`
+        )
+    }
+
+    public async down(queryRunner: QueryRunner): Promise<void> {
+        await queryRunner.query(
+            `ALTER TABLE datasets MODIFY COLUMN name VARCHAR(512)`
+        )
+    }
+}
diff --git a/packages/@ourworldindata/types/src/dbTypes/Datasets.ts b/packages/@ourworldindata/types/src/dbTypes/Datasets.ts
index 4bb4c01579d..eb2121a8d26 100644
--- a/packages/@ourworldindata/types/src/dbTypes/Datasets.ts
+++ b/packages/@ourworldindata/types/src/dbTypes/Datasets.ts
@@ -10,7 +10,7 @@ export interface DbInsertDataset {
     isPrivate?: number
     metadataEditedAt: Date
     metadataEditedByUserId: number
-    name?: string | null
+    name: string
     namespace: string
     nonRedistributable?: number
     shortName?: string | null