From ad3f9fe9090ad50d5de1f661174bd63fa5afae93 Mon Sep 17 00:00:00 2001 From: Sophia Mersmann Date: Wed, 12 Feb 2025 20:31:52 +0100 Subject: [PATCH] =?UTF-8?q?=F0=9F=90=9B=20hide=20editing=20errors=20while?= =?UTF-8?q?=20grapher=20is=20loading?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- adminSiteClient/SaveButtons.tsx | 33 ++++++++++++++++++--------------- 1 file changed, 18 insertions(+), 15 deletions(-) diff --git a/adminSiteClient/SaveButtons.tsx b/adminSiteClient/SaveButtons.tsx index dcae75f749..91385482ea 100644 --- a/adminSiteClient/SaveButtons.tsx +++ b/adminSiteClient/SaveButtons.tsx @@ -157,11 +157,12 @@ class SaveButtonsForChart extends Component<{ (this.narrativeChartNameModalOpen = "closed") } /> - {editingErrors.map((error, i) => ( -
- {error} -
- ))} + {grapher.isReady && + editingErrors.map((error, i) => ( +
+ {error} +
+ ))} ) } @@ -206,11 +207,12 @@ class SaveButtonsForIndicatorChart extends Component<{ ? "Create indicator chart" : "Update indicator chart"} - {editingErrors.map((error, i) => ( -
- {error} -
- ))} + {grapher.isReady && + editingErrors.map((error, i) => ( +
+ {error} +
+ ))} ) } @@ -268,11 +270,12 @@ class SaveButtonsForChartView extends Component<{ > Create DI - {editingErrors.map((error, i) => ( -
- {error} -
- ))} + {grapher.isReady && + editingErrors.map((error, i) => ( +
+ {error} +
+ ))} {this.isCreateDataInsightModalOpen && (