Skip to content

Commit

Permalink
🐝 (svg-tester) add comment
Browse files Browse the repository at this point in the history
  • Loading branch information
sophiamersmann committed Jan 22, 2024
1 parent cea58d0 commit 6296392
Showing 1 changed file with 4 additions and 2 deletions.
6 changes: 4 additions & 2 deletions devTools/svgTester/chart-configurations.ts
Original file line number Diff line number Diff line change
Expand Up @@ -89,6 +89,9 @@ const VIEW_MATRIX_BY_CHART_TYPE: Record<ChartTypeName, ViewMatrix> = {
[ChartTypeName.WorldMap]: {},
}

// the above view matrix is used to generate all possible combinations of query params
// but some combinations don't make sense. this matrix is used to exclude those combinations.
// for example, if a chart is not faceted, the uniformYAxis param doesn't apply
const EXCLUDE_VIEWS_BY_CHART_TYPE: Record<
ChartTypeName,
Record<keyof GrapherQueryParams, string>[]
Expand All @@ -106,8 +109,7 @@ const EXCLUDE_VIEWS_BY_CHART_TYPE: Record<
// selecting the end points only makes sense if a time span is selected
{ time: TimePoint.earliest, endpointsOnly: Boolean.true },
{ time: TimePoint.latest, endpointsOnly: Boolean.true },
// selecting the end points only makes sense if a time span is selected
// and relative mode is not selected
// selecting the end points only makes sense if relative mode is not selected
{ stackMode: StackMode.relative, endpointsOnly: Boolean.true },
// log scale for percentage values doesn't make sense
{ stackMode: StackMode.relative, yScale: ScaleType.log },
Expand Down

0 comments on commit 6296392

Please sign in to comment.