feat(byline): add validation warning

owid · May 23, 2024 · 1352bca · 1352bca
1 parent 64874f2
commit 1352bca
Showing 1 changed file with 15 additions and 0 deletions.
diff --git a/db/model/Gdoc/GdocBase.ts b/db/model/Gdoc/GdocBase.ts
@@ -707,6 +707,20 @@ export class GdocBase implements OwidGdocBaseInterface {
     }
 
     async validate(knex: db.KnexReadonlyTransaction): Promise<void> {
+        const authorErrors = this.content.authors.reduce(
+            (errors: OwidGdocErrorMessage[], name): OwidGdocErrorMessage[] => {
+                if (!this.linkedAuthors.find((a) => a.title === name)) {
+                    errors.push({
+                        property: "linkedAuthors",
+                        message: `Author "${name}" does not exist or is not published`,
+                        type: OwidGdocErrorMessageType.Warning,
+                    })
+                }
+                return errors
+            },
+            []
+        )
+
         const filenameErrors: OwidGdocErrorMessage[] = this.filenames.reduce(
             (
                 errors: OwidGdocErrorMessage[],
@@ -798,6 +812,7 @@ export class GdocBase implements OwidGdocBaseInterface {
 
         const subclassErrors = await this._validateSubclass(knex, this)
         this.errors = [
+            ...authorErrors,
             ...filenameErrors,
             ...linkErrors,
             ...contentErrors,