Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CarNav* RT examples need to be updated #4

Open
peterwvj opened this issue Nov 9, 2015 · 6 comments
Open

CarNav* RT examples need to be updated #4

peterwvj opened this issue Nov 9, 2015 · 6 comments
Labels

Comments

@peterwvj
Copy link
Member

peterwvj commented Nov 9, 2015

Currently we are working on updating the type checker to report an issue with the history expression - see overturetool/overture#472

As a consequence of this fix the CarNav* RT examples (there are two) do not type check anymore. For now I've simply excluded the tests from the ParseTcAllExamplesTest by indicating in the READMEs for these examples that the models do not type check - see da01ba2

That's fine for now. However, what we really need to do is to update the CarNav* examples such that they type check/execute again. The models ship with the tool so we should really fix the errors.

After the models have been fixed we should include them in the ParseTcAllExamplesTest again.

@peterwvj
Copy link
Member Author

This test also has to be re-enabled

Tests run: 49, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 1.074 sec <<< FAILURE!
testCase[18 : CarNaviRadioRT.vdmrt](org.overture.pog.tests.newtests.PogIntegrationTest)  Time elapsed: 0.022 sec  <<< FAILURE!
java.lang.AssertionError: Type Check Error:

        Error 3349: Cannot see non-static operation from static context in 'EnvironmentTask' (CarNaviRadioRT.vdmrt) at line 89:26

Failed tests:
  PogIntegrationTest>ParamStandardTest.testCase:99 Type Check Error:

        Error 3349: Cannot see non-static operation from static context in 'EnvironmentTask' (CarNaviRadioRT.vdmrt) at line 89:26

@ldcouto
Copy link
Member

ldcouto commented Jan 31, 2016

What's the status on this? Are we discontinuing this example or is someone fixing it?

@peterwvj
Copy link
Member Author

I'm not sure that fixing this issue is trivial. We can ask the author of the model if he wants to keep maintaining it as a standard example. According to the examples page @nlmave is the author of the model. Marcel, would you be interested in doing that?

@nlmave
Copy link
Contributor

nlmave commented Feb 1, 2016 via email

@peterwvj
Copy link
Member Author

peterwvj commented Feb 1, 2016

Thanks, Marcel. You are right - I don't think it's the example that has changed. The type error is caused by fixes to the type checker. The problem is explained in overturetool/overture#472

I think the error reported by the type checker makes sense so probably the model needs to be tweaked a bit.

@peterwvj
Copy link
Member Author

PGL told me he fixed the problem with the model in 99cc420 so eventually we should include this model in the examples tests again

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants