Add alumni badge to user after being demoted from Beatmap Nomination using !removebn. #186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add alumni to user specified in !removebn (user) command
kadenbruh
requested review from
cmyui,
tsunyoku and
infernalfire72
as code owners
kadenbruh
changed the title
cmyui
reviewed
Oct 21, 2024
| @@ -274,6 +274,7 @@ async def removebn(fro: str, chan: str, message: list[str]) -> str: | |||
| ) | |||
| await user_utils.set_privileges(targetID, new_privileges) | |||
| await user_utils.remove_user_badge(targetID, badges.BEATMAP_NOMINATION) | |||
| await user_utils.add_user_badge(targetID, badges.ALUMNI) | |||
There was a problem hiding this comment.
should only happen in the case where the user no longer has any staff permissions (e.g. they may also be a chat mod or admin, and just have their bn removed)
There was a problem hiding this comment.
just realized lines 272 & 273:
& ~privileges.USER_DONOR
& ~privileges.USER_PREMIUMthese should also only change when the user no longer has any staff perms
There was a problem hiding this comment.
!addbn should then do the opposite, removing alumni if they already have it & are becoming a staff member again
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add alumni to user specified in !removebn (user) command