Feat/update interface subj dom and some interface features #253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MksmOrlov
requested changes
Jul 11, 2023
MksmOrlov
requested changes
Jul 28, 2023
kb/section_subject_domain_of_ostis_system_interfaces/concepts/concept_data_input_component.scs
Outdated
Show resolved
Hide resolved
...of_ostis_system_interfaces/concepts/concept_data_input_component_without_direct_feedback.scs
Outdated
Show resolved
Hide resolved
kb/section_subject_domain_of_ostis_system_interfaces/concepts/concept_map.scs
Outdated
Show resolved
Hide resolved
kb/section_subject_domain_of_ostis_system_interfaces/NIKA_interface.gwf
Outdated
Show resolved
Hide resolved
kb/section_subject_domain_of_ostis_system_interfaces/NIKA_interface.gwf
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
- Make real values
- Write possible values for font type, size
- Remove lang_en for numbers. Use class
numberfrom ims nrel_system_nameis not about text value in UI components. Rename this relation
MksmOrlov
requested changes
Jul 31, 2023
There was a problem hiding this comment.
Font size is not adaptive. I change it in the KB and see no difference on the interface
There was a problem hiding this comment.
After reloading page I see the old values for a second, then they change to the actual from KB
| @@ -91,13 +93,60 @@ export const App = () => { | |||
| } | |||
| } | |||
| } | |||
|
|
|||
|
|
|||
| async function fetchFontFamily() { | |||
There was a problem hiding this comment.
Write what possible values are for font type
There was a problem hiding this comment.
Make one relation like concept_ui_component_text_value and use it. Do not copy it for the copyright panel, menu button and system name. Use only ine relation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.