[wip] Supporting more midi messages in MidiDrop plugin #1399
Conversation
| }; | ||
| struct MidiTrackEvent { | ||
| static MidiTrackEvent make_note_off(const double start, const midi_size_t ch, const midi_size_t n, const midi_size_t v){ | ||
| return MidiTrackEvent{m_start: start, m_message: Midi::NoteOffData{channel: ch, note: n, velocity: v}}; |
There was a problem hiding this comment.
{m_start: start,
is not valid C++ syntax AFAIK, it should be
.m_start = start
:)
There was a problem hiding this comment.
Mmmh, ok, learning that I like GNU old-style (probably useful when C/C++ didn't agree yet on non positional saving lives in codebases terms) 🙂
How can I make sure my PR isn't going to add warnings?
| @@ -18,11 +18,101 @@ class DropHandler final : public Process::ProcessDropHandler | |||
| const score::DocumentContext& ctx) const noexcept override; | |||
| }; | |||
|
|
|||
| struct PitchbendData{ | |||
There was a problem hiding this comment.
MAybe all of these could go into a more general Midi.hpp ... or, I wonder if it wouldn't be best in libremidi, and then try to consume those directly ? not sure...
There was a problem hiding this comment.
Thanks for the suggestion, I'll start moving it soon then, please let me know what makes most sense.
I was going with MidiTrackEvent as type name (which is the core object along MidiNote which has "pointers" to optional? pair), and considering a "domain" folder:
/domain/MidiNote.hpp moving the current one
/domain/MidiTrackEvent.hpp the detailed header
/domain/Midi.hpp a logical header, including several others, for convenience in other modules.
Do you like this?
| @@ -65,11 +65,8 @@ void DropHandler::dropData( | |||
| const double ratio = song_t / actualDuration.msec(); | |||
| if (ratio != 1.) | |||
| { | |||
| for (auto& note : track.notes) | |||
| { | |||
| midi_size_t velocity; | ||
| }; | ||
| struct MidiTrackEvent { | ||
| static MidiTrackEvent make_note_off(const double start, const midi_size_t ch, const midi_size_t n, const midi_size_t v){ |
There was a problem hiding this comment.
these functions look a lot like the ones in libremidi, maybe it should go there ?
…nothing is handled in the UI yet, but it parses the MidiTrackEvent objects.
smoothdeveloper
force-pushed
the
midi-more-data
branch
from
b4d9700 to
ba90398
Compare
jcelerier
force-pushed
the
master
branch
7 times, most recently
from
66a7ad0 to
5dc8d48
Compare
jcelerier
force-pushed
the
master
branch
9 times, most recently
from
9a9b382 to
28c6d0a
Compare
|
hello ! just so you know - as this was requested in many places I added a very small separate "midi reader" object which will take a midi file explicitly and output every message, as well as a "midi filter" object which is able to filter a specific CC, pitch bend, after touch, etc... message. It's availble in the current nightlies |
jcelerier
force-pushed
the
master
branch
2 times, most recently
from
ac5bf9a to
fd8efed
Compare
This is wip of a first iteration on supporting a bit more of the midi messages in Score.
current scope
Guidance appreciated, including pointers for: