Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix brew style warnings in gz-<collection>.rb files #2986

Merged
merged 1 commit into from
Feb 21, 2025
Merged

Fix brew style warnings in gz-<collection>.rb files #2986

merged 1 commit into from
Feb 21, 2025

Conversation

iche033
Copy link
Contributor

@iche033 iche033 commented Feb 21, 2025

Fix brew test-bot warnings such as:

  Taps/osrf/homebrew-simulation/Formula/gz-garden.rb:44:5: C: [Correctable] FormulaAudit/AssertStatements: Use assert_path_exists <path_to_file> instead of assert_predicate share/"gz/gz-garden/gazebodistro/collection-garden.yaml", :exist?
      assert_predicate share/"gz/gz-garden/gazebodistro/collection-garden.yaml", :exist?

@iche033
fixing warnings
52d8444 
Signed-off-by: Ian Chen <ichen@openrobotics.org>
@iche033 iche033 requested a review from scpeters as a code owner February 21, 2025 00:18
@iche033 iche033 mentioned this pull request Feb 21, 2025
Merged
@scpeters scpeters merged commit bb7007e into master Feb 21, 2025
1 check passed
@scpeters scpeters deleted the brew_warnings branch February 21, 2025 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scpeters scpeters scpeters approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iche033 @scpeters