Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add multi threading feature #6

Open
AntoJvlt opened this issue Aug 22, 2021 · 0 comments
Open

Add multi threading feature #6

AntoJvlt opened this issue Aug 22, 2021 · 0 comments
Labels
enhancement New feature or request

Comments

@AntoJvlt
Copy link
Collaborator

Adding multi threading to the tool would reduce a lot the time needed to execute all the rules. As python threads run concurrently the real benefit will come when query are executed on the PostgreSQL server (maybe by using a connection pool) and when we call clustering-vt. Clustering-vt and PostgreSQL queries are the most time consuming operations when executing a rule so threads would definitively improve the performance of the tool.

It can be interesting to check if it would be better to execute a whole rule in its own thread or if threads would be spawn locally when executing PostgreSQL queries and when calling clustering-vt.

In the first case, we should make sure some operations are thread safe, for example when accessing the config or when writing/reading to files.

@AntoJvlt AntoJvlt added the enhancement New feature or request label Aug 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant