osbuild: do not assume osbuild stage messages have a final \n #1201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit tweaks the osbuild monitor code to deal correctly with messages from osbuild stage that may not contain a final newline. So far the code assumed this and stripped the final newline when storing the message in the status. But sometimes there are messages without a final \n (e.g. when messages get very long). So just put the message in verbatim and let the caller do a "print" instead of a "println" when processing the messages (arguably the trim for traces was always strong).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[draft as this needs coresponding image-builder-cli/bib changs]
This commit tweaks the osbuild monitor code to deal correctly with messages from osbuild stage that may not contain a final newline. So far the code assumed this and stripped the final newline when storing the message in the status. But sometimes there are messages without a final \n (e.g. when messages get very long). So just put the message in verbatim and let the caller do a "print" instead of a "println" when processing the messages (arguably the trim for traces was always strong).