imagefilter: improve supported filters discoverability #1198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit tweaks the error message for unsupported filter prefixes to include what is actually supported. See osbuild/image-builder-cli#104
This commit adds a new `SupportedFilter()` function that returns the available filter prefixes. See osbuild/image-builder-cli#104
supakeen
previously approved these changes
Feb 10, 2025
This commit moves the "loose" strings for the filtering into
consts. Thanks to Simon for the suggestion.
Fwiw, we could also move this [0] into a
```go
var supportedFilters map[string]prefixMatchFunc{
"distro": matcherFuncDistro,
...
}
```
which would mean the supportedFilters function and the actual
supported things can never go out of sync. The downside is that
we would still need to maintain the order of the supported filters
manually as some are just way more useful than others so naively
sorting goes not give the best user experience.
[0] See
osbuild@5e50e93
for a full version.
Sure thing, I updated the code with that (and some musings about possible other approaches). |
supakeen
approved these changes
Feb 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
imagefilter: add
SupportedFilter()that returns knownprefixes
This commit adds a new
SupportedFilter()function that returnsthe available filter prefixes.
See osbuild/image-builder-cli#104
imagefilter: show supported filters when giving one
This commit tweaks the error message for unsupported filter prefixes
to include what is actually supported.
See osbuild/image-builder-cli#104