Add support for custom partition types/GUIDs in blueprints #1115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thozza
approved these changes
Jan 9, 2025
There was a problem hiding this comment.
LGTM 👍
Edit: I incline to Brian's comment #1116 (comment), but I don't have a strong preference.
thozza
force-pushed
the
partition-types
branch
from
7abbefe to
fb31aaf
Compare
|
Rebased due to image build cache layout change (#1130) |
|
This PR is stale because it has been open 30 days with no activity. Remove "Stale" label or comment or this will be closed in 7 days. |
I also like
|
People need to customize partitition types/GUIDs, so this commit adds this option to the blueprint. It's technically a partition type for DOS partitions, but the key type is already taken, so let's go with guid both for DOS and GPT.
This commit takes the blueprint customization added in the last commit, and makes it actually useful.
thozza
force-pushed
the
partition-types
branch
from
fb31aaf to
c93c654
Compare
|
Are we changing the option to |
I vote for changing it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce the ability to specify custom partition types/GUIDs for both DOS and GPT partition types.
For DOS partitions, the field is technically called type, but this is already a taken field, so I went with GUID from the GPT vocabulary for the new field name.