Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

osbuild: add support for swap in the bootupd stage #1087

Merged
merged 1 commit into from
Dec 5, 2024

Conversation

mvo5
Copy link
Contributor

@mvo5 mvo5 commented Dec 5, 2024

Trivial commit to allow swap in bootupd.

Copy link
Member

@ondrejbudai ondrejbudai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't we need to handle swap on LV as well?

@mvo5 mvo5 force-pushed the fix-bootupd-swap branch from d8986c0 to d148292 Compare December 5, 2024 12:02
@mvo5
Copy link
Contributor Author

mvo5 commented Dec 5, 2024

Don't we need to handle swap on LV as well?

Excellent point! Added now (my integration test run in bib did not quite yet go to the lvm part :)

@mvo5 mvo5 requested a review from ondrejbudai December 5, 2024 12:03
ondrejbudai
ondrejbudai previously approved these changes Dec 5, 2024
Copy link
Member

@ondrejbudai ondrejbudai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two nitpicks, but otherwise this is great! :)

pkg/osbuild/bootupd_stage.go Outdated Show resolved Hide resolved
pkg/osbuild/bootupd_stage.go Outdated Show resolved Hide resolved
Add support for swap in bootupd device generation for both plain
and LVM partitions.
Copy link
Member

@ondrejbudai ondrejbudai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! :)

@ondrejbudai ondrejbudai enabled auto-merge December 5, 2024 12:44
@ondrejbudai ondrejbudai added this pull request to the merge queue Dec 5, 2024
Merged via the queue into osbuild:main with commit 076c920 Dec 5, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants