Segfault in finalizer with native addon on Macosx Ventura

[shawngardner]

After upgrading Macosx to v13.0 Ventura, we are receiving a segfault when using AWS SDKs or AWS CDK. In all of these cases it seems to be due to the shared native addons in awslabs/aws-crt-nodejs.

Since it very much seems to be related to the Ventura upgrade, I figured I'd start a discussion here instead of opening scattershot issues in various repos.

OS/Version	Node Version	Result
Macosx Ventura v13.0 (Intel)	v14.21.1 v16.18.0 v18.12.1 v19.0.1	🚫 segfault
Macosx Big Sur v11.7.1 (Intel)	v14.21.1 v16.18.0 v18.12.1 v19.0.1	🆗
Macosx Monterey v12.6.1 (Intel)	v14.21.1 v16.18.0 v18.12.1 v19.0.1	🆗
Various Linux-based containers	v14.21.1 v16.18.0 v18.12.1 v19.0.1	🆗

To repro:

> npm i aws-crt@1.14.5

> const crt = require('aws-crt'); const req = new crt.http.HttpRequest('GET', 'https://www.google.com');

Signal received: 11, errno: 0
  SIGSEGV @ 0x0x1d9
################################################################################
Stack trace:
################################################################################
1   aws-crt-nodejs.node                 0x0000000132010e83 s_print_stack_trace + 19
2   libsystem_platform.dylib            0x00007ff808641c1d _sigtramp + 29
3   ???                                 0x0000000000000000 0x0 + 0
4   aws-crt-nodejs.node                 0x0000000132010f11 s_napi_context_finalize + 129
5   node                                0x000000010c90b993 _ZN10napi_env__14CallIntoModuleIRZN15node_napi_env__13CallFinalizerILb1EEEvPFvPS_PvS4_ES4_S4_EUlS3_E_ZNS1_18CallbackIntoModuleILb1ES7_EEvOT0_EUlS3_N2v85LocalINSC_5ValueEEEE_EEvOT_SB_ + 67
6   node                                0x000000010c90814d _ZN15node_napi_env__13CallFinalizerILb1EEEvPFvP10napi_env__PvS3_ES3_S3_ + 109
7   node                                0x000000010c8ef9b0 _ZN6v8impl9Reference8FinalizeEb + 96
8   node                                0x000000010c907f4b _ZN15node_napi_env__8DeleteMeEv + 43
9   node                                0x000000010c90b0a4 _ZN6v8impl12_GLOBAL__N_118ThreadSafeFunctionD1Ev + 324
10  node                                0x000000010c90b18e _ZN6v8impl12_GLOBAL__N_118ThreadSafeFunctionD0Ev + 14
11  node                                0x000000010c90b4a1 _ZZN4node11Environment11CloseHandleI11uv_handle_sZN6v8impl12_GLOBAL__N_118ThreadSafeFunction26CloseHandlesAndMaybeDeleteEbEUlPS2_E_EEvPT_T0_ENUlS6_E_8__invokeES6_ + 545
12  node                                0x000000010d49c967 uv_run + 695
13  node                                0x000000010c8de529 _ZN4node11Environment14CleanupHandlesEv + 377
14  node                                0x000000010c8ded9c _ZN4node11Environment10RunCleanupEv + 668
15  node                                0x000000010c8789d5 _ZN4node15FreeEnvironmentEPNS_11EnvironmentE + 117
16  node                                0x000000010c98481a _ZN4node16NodeMainInstance3RunEv + 234
17  node                                0x000000010c905fb8 _ZN4node22LoadSnapshotDataAndRunEPPKNS_12SnapshotDataEPKNS_24InitializationResultImplE + 440
18  node                                0x000000010c906259 _ZN4node5StartEiPPc + 633
19  dyld                                0x00007ff8082e6310 start + 2432

The segfault trace above was captured on Node 18/19. On 14 and 16 we were not able to grab a segfault trace using ddopson/node-segfault-handler.

[Trott]

@nodejs/platform-macos

[bnoordhuis]

Probably something in that add-on. That s_napi_context_finalize function is misleadingly named because it's not a n-api function, it's from the add-on:

https://github.com/awslabs/aws-crt-nodejs/blob/b31d0c20ba6a7d10dbf4aa5c46a16f455296328c/source/module.c#L881-L905

I'd start by opening an issue over there.

[shawngardner]

Ah, sorry, should have looked harder at the source there. Thanks, will open an issue there.