Fix Mapping, Remove Dummy UTXOs, Support Edge Cases (current) #29
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing: #2
Refactor of selectUtxos() and generatePsbtBuyingInscription()
-Inscriptions will now always be at satIndex 0 of the taker's receiving output
-Dummy UTXOs to assert index match requirements of sighashsingle are now unecessary
With the new PSBT construction, the inscribed output may in many cases be the last output of the transaction. In any cases where the fees for the PSBT would result in the inscribed output being less than 2k sats in value, the taker will be required to provide additional inputs to cover these fees. If the additional inputs provided are also sufficient to add padding back to the inscribed output, they will be used (up to 10k value). -Note: The taker still owns these sats, they're just preserving the padding.
This is an updated pull request reflecting the current features for openordex
I'm uncertain why the diff generated is being stubborn.
All changes refer to
selectUtxos()
generatePsbtBuyingInscription()
updatePayerAddress()
Changes can be found both in the function definitions and as they are called.