-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow sending sat #3200
feat: allow sending sat #3200
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good so far. This definitely needs an integration test in tests/wallet/send.rs
src/subcommand/wallet/send.rs
Outdated
@@ -66,6 +66,14 @@ impl Send { | |||
self.fee_rate, | |||
false, | |||
)?, | |||
Outgoing::Sat(sat) => Self::create_unsigned_send_sat_transaction( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You could probably just use the send_satpoint function and call wallet.find_sat_in_outputs(sat)? directly in the function arguments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice tips
@raphjaph code review, plz ~ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Getting there, just some small points. Test is also still failing I think.
ord git:(feat/allow-send-sat) cargo test send_inscription_by_sat git:(feat/allow-send-sat|)
Finished test [unoptimized + debuginfo] target(s) in 0.50s
Running unittests src/lib.rs (target/debug/deps/ord-0d4fe9b518998753)
running 0 tests
test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 666 filtered out; finished in 0.00s
Running unittests src/bin/main.rs (target/debug/deps/ord-9e65a5af59a3acca)
running 0 tests
test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s
Running tests/lib.rs (target/debug/deps/integration-93716b75a14687f2)
running 1 test
test wallet::send::send_inscription_by_sat ... ok
test result: ok. 1 passed; 0 failed; 0 ignored; 0 measured; 223 filtered out; finished in 0.78s |
Could you merge in the latest changes? Also try running all tests with |
I think the tests are still failing for normal reasons, not flaky reasons |
@raphjaph I'm sorry. I made a mistake by using the first sat after sorting the results returned by "ord wallet sat" as the subscribed inscription's sat |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Description
add send sat
Related Issue
Related #3117
Code Review Request
use:
let satpoint = wallet.find_sat_in_outputs(sat)?;
input sat and get satpoint,and then call
create_unsigned_send_satpoint_transaction
but withsending_inscription=true
,