[GR-18163] Call unblock functions using JNI in CExtInterrupter #3385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
graalvmbot
commented
Jan 12, 2024
•
graalvmbot
commented
- Cleanup
- Call unblock functions using JNI in CExtInterrupter
- We cannot enter TruffleContext on a system thread, so that leaves us with two options:
- Calling the unblock function with JNI, and expect the unblock function does not call back to Ruby (not the case for all unblock functions I saw).
- Calling the unblock function on a new Ruby Thread per context and communicate via a queue, but this seems very high overhead for every guest safepoint.
- Fixes [Bug / Concurrency] CPU sampler during multi threaded operation yields error: Context cannot be entered on system threads #3013
- We cannot enter TruffleContext on a system thread, so that leaves us with two options:
oracle-contributor-agreement
bot
added
the
OCA Verified
* We cannot enter TruffleContext on a system thread, so that leaves us with two options: * Calling the unblock function with JNI, and expect the unblock function does not call back to Ruby (not the case for all unblock functions I saw). * Calling the unblock function on a new Ruby Thread per context and communicate via a queue, but this seems very high overhead for every guest safepoint. * Fixes #3013
graalvmbot
force-pushed
the
bd/system-thread-cext-interrupter-jni
branch
from
dc18cb2 to
6bbd0de
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.