Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add filesystem fixes required for UEK 6 images to be built on UEK 7 #9

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add filesystem fixes required for UEK 6 images to be built on UEK 7 #9

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions build-image/format-disk.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
#! /bin/bash
#
# Copyright (c) 2024, Oracle and/or its affiliates.
# Copyright (c) 2024,2025 Oracle and/or its affiliates.
# Licensed under the Universal Permissive License v 1.0 as shown at https://oss.oracle.com/licenses/upl.
set -e
set -x
Expand Down Expand Up @@ -36,6 +36,6 @@ BOOT_DEVICE=$(blkid | grep "${DEVICE}" | grep 'PARTLABEL="boot"' | cut -f1 -d' '

# Make filesystems
mkfs.fat -F 32 -n "$EFI_PARTITION_LABEL" "$EFI_DEVICE"
mkfs.xfs -f -m bigtime=0 -L "$BOOT_PARTITION_LABEL" "$BOOT_DEVICE"
"mkfs.$FILESYSTEM" -f -L "$ROOT_PARTITION_LABEL" "$ROOT_DEVICE"
mkfs.xfs -f -m bigtime=0,inobtcount=0,reflink=0 -L "$BOOT_PARTITION_LABEL" "$BOOT_DEVICE"
"mkfs.$FILESYSTEM" -f -m bigtime=0,inobtcount=0,reflink=0 -L "$ROOT_PARTITION_LABEL" "$ROOT_DEVICE"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this command work if the filesystem is not xfs?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would the filesystem ever not be xfs?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the context of format-disk.sh, the filesystem to use is passed in. If it is the case that only xfs is supported then this script could be changed to reflect that