Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separated UI components into @optuna/react (Continued from #851) #862

Merged
merged 20 commits into from
Apr 12, 2024

Conversation

porink0424
Copy link
Collaborator

@porink0424 porink0424 commented Apr 10, 2024

Contributor License Agreement

This repository (optuna-dashboard) and Goptuna share common code.
This pull request may therefore be ported to Goptuna.
Make sure that you understand the consequences concerning licenses and check the box below if you accept the term before creating this pull request.

  • I agree this patch may be ported to Goptuna by other Goptuna contributors.

Reference Issues/PRs

Continued from #851

What does this implement/fix? Explain your changes.

  • As the continuation of Separated some UI components into @optuna/react #851, separated UI components into @optuna/react to make codes common
    • In this PR, the following components were moved:
      • PlotImportance
      • PlotIntermediateValues
    • Tests for components above are also added.
  • Add importance prop in PlotImportance so that importance can be calculated outside
    • Because if @optuna/react has a dependency for wasm, it would destroy the merit that who developing the main body of dashboard did not have to build the rust env.

@c-bata c-bata merged commit 8704166 into optuna:main Apr 12, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants