Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move config files to under the optuna_dashboard directory. #847

Merged
merged 5 commits into from
Mar 22, 2024

Conversation

c-bata
Copy link
Member

@c-bata c-bata commented Mar 22, 2024

Contributor License Agreement

This repository (optuna-dashboard) and Goptuna share common code.
This pull request may therefore be ported to Goptuna.
Make sure that you understand the consequences concerning licenses and check the box below if you accept the term before creating this pull request.

  • I agree this patch may be ported to Goptuna by other Goptuna contributors.

Reference Issues/PRs

An alternative approach for #845.

What does this implement/fix? Explain your changes.

Move config files to under the optuna_dashboard directory.

Copy link

codecov bot commented Mar 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.51%. Comparing base (e82d3b9) to head (7cb89d7).
Report is 7 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #847      +/-   ##
==========================================
- Coverage   69.60%   69.51%   -0.09%     
==========================================
  Files          35       35              
  Lines        2375     2375              
==========================================
- Hits         1653     1651       -2     
- Misses        722      724       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@porink0424 porink0424 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks almost good, but we also have to exclude typescript_tests/** from biome.js?

@c-bata
Copy link
Member Author

c-bata commented Mar 22, 2024

Thank you for your review! Good catch. I fixed the biome.json. Could you take a look again?

biome.json Outdated
Comment on lines 7 to 8
"optuna_dashboard/ts/tests/**/*.ts",
"optuna_dashboard/ts/tests/**/*.tsx",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we can just delete these (I think these are already included into two lines above these).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, you are right 🙏

biome.json Outdated Show resolved Hide resolved
@c-bata c-bata merged commit c2bdbcd into optuna:main Mar 22, 2024
17 checks passed
@c-bata c-bata deleted the change-repository-structure branch March 22, 2024 05:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants