-
-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move config files to under the optuna_dashboard
directory.
#847
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #847 +/- ##
==========================================
- Coverage 69.60% 69.51% -0.09%
==========================================
Files 35 35
Lines 2375 2375
==========================================
- Hits 1653 1651 -2
- Misses 722 724 +2 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks almost good, but we also have to exclude typescript_tests/**
from biome.js
?
Thank you for your review! Good catch. I fixed the |
biome.json
Outdated
"optuna_dashboard/ts/tests/**/*.ts", | ||
"optuna_dashboard/ts/tests/**/*.tsx", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we can just delete these (I think these are already included into two lines above these).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, you are right 🙏
Contributor License Agreement
This repository (
optuna-dashboard
) and Goptuna share common code.This pull request may therefore be ported to Goptuna.
Make sure that you understand the consequences concerning licenses and check the box below if you accept the term before creating this pull request.
Reference Issues/PRs
An alternative approach for #845.
What does this implement/fix? Explain your changes.
Move config files to under the
optuna_dashboard
directory.