Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove a warning message of PedAnovaImportanceEvaluator #823

Merged
merged 1 commit into from
Mar 5, 2024

Conversation

c-bata
Copy link
Member

@c-bata c-bata commented Mar 5, 2024

Contributor License Agreement

This repository (optuna-dashboard) and Goptuna share common code.
This pull request may therefore be ported to Goptuna.
Make sure that you understand the consequences concerning licenses and check the box below if you accept the term before creating this pull request.

  • I agree this patch may be ported to Goptuna by other Goptuna contributors.

Reference Issues/PRs

Refs #820

What does this implement/fix? Explain your changes.

Remove a warning message since it isn't a problem to use Optuna Dashboard with optuna<3.6.0.

@nabenabe0928 nabenabe0928 self-assigned this Mar 5, 2024
Copy link
Collaborator

@nabenabe0928 nabenabe0928 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for addressing the issue, probably it is better removing it to avoid complications.

Copy link

codecov bot commented Mar 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.60%. Comparing base (7708a1f) to head (dbec8c6).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #823      +/-   ##
==========================================
- Coverage   69.61%   69.60%   -0.02%     
==========================================
  Files          35       35              
  Lines        2376     2375       -1     
==========================================
- Hits         1654     1653       -1     
  Misses        722      722              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@c-bata
Copy link
Member Author

c-bata commented Mar 5, 2024

@nabenabe0928 Thank you for your review!

@c-bata
Copy link
Member Author

c-bata commented Mar 5, 2024

Let me merge this PR, since the cause of CI failure is obviously not related to this PR.

@c-bata c-bata merged commit 059f575 into optuna:main Mar 5, 2024
14 of 15 checks passed
@c-bata c-bata deleted the remove-warning-message-ped-anova branch March 5, 2024 04:30
@nabenabe0928 nabenabe0928 removed their assignment Mar 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants