Add e2e test for loading journal storage in standalone app #782
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #782 +/- ##
==========================================
+ Coverage 69.13% 69.61% +0.47%
==========================================
Files 35 35
Lines 2378 2376 -2
==========================================
+ Hits 1644 1654 +10
+ Misses 734 722 -12 ☔ View full report in Codecov by Sentry. |
|
@gen740 @nabenabe0928 Could you review this PR? |
gen740
suggested changes
Feb 2, 2024
keisuke-umezawa
force-pushed
the
feature/add-e2e-test-journal-storage
branch
from
2167f77 to
da0cca1
Compare
keisuke-umezawa
force-pushed
the
feature/add-e2e-test-journal-storage
branch
from
da0cca1 to
f0751b8
Compare
|
@gen740 |
Co-authored-by: Shuhei Watanabe <47781922+nabenabe0928@users.noreply.github.com>
|
@nabenabe0928 @gen740 I fixed it. Could you review it again? |
gen740
approved these changes
Mar 18, 2024
nabenabe0928
approved these changes
Mar 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributor License Agreement
This repository (
optuna-dashboard) and Goptuna share common code.This pull request may therefore be ported to Goptuna.
Make sure that you understand the consequences concerning licenses and check the box below if you accept the term before creating this pull request.
Reference Issues/PRs
To follow-up on #732
What does this implement/fix? Explain your changes.
Add e2e test for loading journal storage in standalone app