Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a minor bug that upload_artifact api does not return the latest artifacts. #713

Merged
merged 1 commit into from
Nov 28, 2023

Conversation

c-bata
Copy link
Member

@c-bata c-bata commented Nov 28, 2023

Contributor License Agreement

This repository (optuna-dashboard) and Goptuna share common code.
This pull request may therefore be ported to Goptuna.
Make sure that you understand the consequences concerning licenses and check the box below if you accept the term before creating this pull request.

  • I agree this patch may be ported to Goptuna by other Goptuna contributors.

Reference Issues/PRs

None

What does this implement/fix? Explain your changes.

Fix a minor bug that upload_artifact api does not return the latest artifacts.

@c-bata c-bata changed the title Fix a minor bug that upload_artifact api does not return the latest artifacts. Fix a minor bug that upload_artifact api does not return the latest artifacts. Nov 28, 2023
Copy link

codecov bot commented Nov 28, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (bf7c930) 63.77% compared to head (265dfb4) 65.20%.
Report is 26 commits behind head on main.

Files Patch % Lines
optuna_dashboard/artifact/_backend.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #713      +/-   ##
==========================================
+ Coverage   63.77%   65.20%   +1.43%     
==========================================
  Files          35       35              
  Lines        2280     2285       +5     
==========================================
+ Hits         1454     1490      +36     
+ Misses        826      795      -31     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@c-bata c-bata merged commit 520d4d3 into optuna:main Nov 28, 2023
13 checks passed
@c-bata c-bata deleted the fix-upload-trial-artifact branch November 28, 2023 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant