Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use plot_param_importances in backend #683

Closed
wants to merge 2 commits into from

Conversation

knshnb
Copy link
Member

@knshnb knshnb commented Nov 7, 2023

Contributor License Agreement

This repository (optuna-dashboard) and Goptuna share common code.
This pull request may therefore be ported to Goptuna.
Make sure that you understand the consequences concerning licenses and check the box below if you accept the term before creating this pull request.

  • I agree this patch may be ported to Goptuna by other Goptuna contributors.

Reference Issues/PRs

What does this implement/fix? Explain your changes.

Sorry, something went wrong.

Copy link

codecov bot commented Nov 7, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (5c2bc4a) 68.20% compared to head (ca6a88d) 68.16%.
Report is 1 commits behind head on main.

Files Patch % Lines
optuna_dashboard/_app.py 50.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #683      +/-   ##
==========================================
- Coverage   68.20%   68.16%   -0.05%     
==========================================
  Files          35       35              
  Lines        2334     2340       +6     
==========================================
+ Hits         1592     1595       +3     
- Misses        742      745       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@HideakiImamura
Copy link
Member

@nabenabe0928 Could you review this PR?

@knshnb
Copy link
Member Author

knshnb commented Nov 7, 2023

@HideakiImamura Sorry to confuse you, but this is just a prototype and not ready for review currently.

@HideakiImamura
Copy link
Member

Oh, I see. I reset the assignees.

Copy link

github-actions bot commented Jan 7, 2024

This pull request has not seen any recent activity.

@github-actions github-actions bot added the stale for stale bot label Jan 7, 2024
@github-actions github-actions bot removed the stale for stale bot label Jan 14, 2024
@c-bata
Copy link
Member

c-bata commented Feb 2, 2024

@knshnb Should we close this PR?

@knshnb
Copy link
Member Author

knshnb commented Feb 2, 2024

Let me close this because I worked on this with other PRs: #764

@knshnb knshnb closed this Feb 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants