Change the definition of union_search_space, intersect_search_space
#1026
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
porink0424
changed the title
union_search_spaceunion_search_space, intersect_search_space
…x/trial-table-duplicates-values
c-bata
reviewed
Feb 19, 2025
c-bata
reviewed
Feb 19, 2025
Comment on lines
132
to
135
| for n1, d1 in trial.distributions.items(): | ||
| for n2, d2 in self._union_search_space: | ||
| if n1 == n2: | ||
| if _is_same_float_distribution(d1, d2): |
There was a problem hiding this comment.
I'm just wondering if there's a better approach to mitigate this deeply nested code. Do you think we could define functions like the following to make the code easier to read?
def get_union_search_space(space_1, space_2) -> ...:
...
def get_intersection_search_space(space_1, space_2) -> ...:
...There was a problem hiding this comment.
I reduced the nesting by one level, but I couldn't think of a good way to simplify it further...
The functions you mentioned might not be the best since original code requires break inside an if statement.
c-bata
approved these changes
Feb 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributor License Agreement
This repository (
optuna-dashboard) and Goptuna share common code.This pull request may therefore be ported to Goptuna.
Make sure that you understand the consequences concerning licenses and check the box below if you accept the term before creating this pull request.
Reference Issues/PRs
Fixes #1012
What does this implement/fix? Explain your changes.
The following changes have been made:
search_spaceremains the same.TrialTablewhere parameters with the same name resulted in identical row IDs, causing duplicate key props and triggering a React warning.