-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable new ax #255
Open
shuds13
wants to merge
21
commits into
main
Choose a base branch
from
enable_new_ax
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Enable new ax #255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 335c08a.
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A continuation of #239
The multitask example has been updated and now works in the Standalone example.
I don't know if all the new fields in MT_MTGP_trans are necessary
The Single Fidelity example also needs updates for Ax 0.5.0
It looks like the different models GPEI, MOO have been replaced by BOTORCH_MODULAR (and FULLYBAYESIANMOO/ FULLYBAYESIAN by SAASBO), which apparently infers acquisition function from the optimization config (e.g., the number of objectives). The single fidelity test runs with this.
test_ax_generators.py:
This change is also required in test_ax_generators.py
Fails in test_ax_generators.py -> test_ax_multi_fidelity():
TypeError: Unexpected keyword argument
X_pending
when constructing input arguments for construct_inputs_qMFKG.' Similar for constraints. It runs if I remove these fromacquisition_options
.In test test_ax_service_init()
assert df["generation_method"][j] == "Manual"
fails, gettingNone
instead for the user added trial. It seems to happen since_maybe_transition_to_next_node()
is called (previously_maybe_move_to_next_step()
) in optimas/generators/ax/service.base.py andgeneration_methods.add("Manual")
in Ax's report_utils.py does not get run. For now, changed test to expectNone
but this should be checked. Otherwise test seems to function correctly with these trials replacing the sobol steps.There is also still quite a number of warnings.
see:
https://github.com/facebook/Ax/releases/tag/0.5.0 (fifth bullet).
https://ax.dev/docs/models/ (using BOTORCH_MODULAR)