Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump spotless 2.44.2 and format code #2661

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

csviri
Copy link
Collaborator

@csviri csviri commented Jan 8, 2025

Signed-off-by: Attila Mészáros a_meszaros@apple.com

Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
}
}
static boolean getBooleanFromSystemPropsOrDefault(String propertyName,
boolean defaultValue) {var property=System.getProperty(propertyName);if(property==null){return defaultValue;}else{property=property.trim().toLowerCase();return switch(property){case"true"->true;case"false"->false;default->defaultValue;};}}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, that doesn't seem right

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wow, interesting, not sure, will take a look a look later, this might be a bug in spotless

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

even 2.44.2 is not fixing it we might want just ignore this for now, and create an issue for spotless?!

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, there seems something wrong with 2.44

Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
@csviri csviri changed the title chore: bump spotless 2.44.1 and format code chore: bump spotless 2.44.2 and format code Jan 15, 2025
@csviri csviri requested a review from metacosm January 15, 2025 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants