Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update to Fabric8 7.0-SNAPSHOT & replace APT by maven plugin #2613

Merged
merged 2 commits into from
Dec 2, 2024

Conversation

metacosm
Copy link
Collaborator

@metacosm metacosm commented Dec 2, 2024

Signed-off-by: Bernhard Strähle bernhard.straehle@gmail.com
Signed-off-by: Chris Laprun claprun@redhat.com

@metacosm metacosm self-assigned this Dec 2, 2024
@metacosm metacosm requested review from csviri and xstefank December 2, 2024 10:15
Copy link
Collaborator

@xstefank xstefank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only I don't understand if we want to have snapshot dependency on main so the project is not buildable?

@csviri
Copy link
Collaborator

csviri commented Dec 2, 2024

Yeah, this is questionable in general, if we should merge this now. But we can always revert if there would be an issue with a fabric8 snapshot release.

I'm also working on an issue that requires the snapshot fabric8 so it is fine to merge for me now.

@metacosm
Copy link
Collaborator Author

metacosm commented Dec 2, 2024

This is targeting the next branch, btw. And the idea is to have the changes in the code now to get ready for the impending release of the client in version 7. The snapshot repo access should, of course, be removed before we merge to main.

Signed-off-by: Bernhard Strähle <bernhard.straehle@gmail.com>
Signed-off-by: Chris Laprun <claprun@redhat.com>
Signed-off-by: Chris Laprun <claprun@redhat.com>
@metacosm metacosm requested review from csviri and xstefank December 2, 2024 14:33
@metacosm metacosm merged commit 1cb59d5 into next Dec 2, 2024
45 checks passed
@metacosm metacosm deleted the fabric8-7-next branch December 2, 2024 15:01
csviri pushed a commit that referenced this pull request Dec 6, 2024
…2613)

* chore: update to Fabric8 7.0-SNAPSHOT & replace APT by maven plugin

Signed-off-by: Bernhard Strähle <bernhard.straehle@gmail.com>
Signed-off-by: Chris Laprun <claprun@redhat.com>

* chore(docs): add Fabric8 7 migration information

Signed-off-by: Chris Laprun <claprun@redhat.com>

---------

Signed-off-by: Bernhard Strähle <bernhard.straehle@gmail.com>
Signed-off-by: Chris Laprun <claprun@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants