improve: mapping from annotation depends on type #2606
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Attila Mészáros <a_meszaros@apple.com> compiles Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
csviri
requested review from
xstefank and
adam-sandor
and removed request for
adam-sandor
xstefank
approved these changes
Nov 26, 2024
Signed-off-by: Chris Laprun <claprun@redhat.com>
Signed-off-by: Chris Laprun <claprun@redhat.com>
Signed-off-by: Chris Laprun <claprun@redhat.com>
Signed-off-by: Chris Laprun <claprun@redhat.com>
metacosm
approved these changes
Nov 27, 2024
metacosm
added a commit
that referenced
this pull request
Nov 27, 2024
* improve: mapping from annotation depends on type Signed-off-by: Attila Mészáros <a_meszaros@apple.com> compiles Signed-off-by: Attila Mészáros <a_meszaros@apple.com> * refactor: avoid creating useless strings Signed-off-by: Chris Laprun <claprun@redhat.com> * refactor: ensure roundtrip works Signed-off-by: Chris Laprun <claprun@redhat.com> * refactor: rename toSimpleString to toGVKString for greater clarity Signed-off-by: Chris Laprun <claprun@redhat.com> * refactor: minor improvements Signed-off-by: Chris Laprun <claprun@redhat.com> --------- Signed-off-by: Attila Mészáros <a_meszaros@apple.com> Signed-off-by: Chris Laprun <claprun@redhat.com> Co-authored-by: Chris Laprun <claprun@redhat.com>
This was referenced Dec 3, 2024
csviri
added a commit
that referenced
this pull request
Dec 6, 2024
* improve: mapping from annotation depends on type Signed-off-by: Attila Mészáros <a_meszaros@apple.com> compiles Signed-off-by: Attila Mészáros <a_meszaros@apple.com> * refactor: avoid creating useless strings Signed-off-by: Chris Laprun <claprun@redhat.com> * refactor: ensure roundtrip works Signed-off-by: Chris Laprun <claprun@redhat.com> * refactor: rename toSimpleString to toGVKString for greater clarity Signed-off-by: Chris Laprun <claprun@redhat.com> * refactor: minor improvements Signed-off-by: Chris Laprun <claprun@redhat.com> --------- Signed-off-by: Attila Mészáros <a_meszaros@apple.com> Signed-off-by: Chris Laprun <claprun@redhat.com> Co-authored-by: Chris Laprun <claprun@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.