Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: context getSecondary resource is activation condition aware #2532

Merged
merged 3 commits into from
Sep 23, 2024
Merged

feat: context getSecondary resource is activation condition aware #2532

merged 3 commits into from
Sep 23, 2024

Conversation

csviri
Copy link
Collaborator

@csviri csviri commented Sep 17, 2024 •
edited
Loading

No description provided.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 17, 2024
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 17, 2024
@csviri csviri changed the base branch from main to next September 17, 2024 15:09
@csviri csviri changed the title secondary activation feat: context getSecondary resource is activation conidition aware Sep 17, 2024
@csviri csviri linked an issue Sep 17, 2024 that may be closed by this pull request
Context.getSecondaryResource(A.class) should return Optional.empty when activationCondition not met #2198
Closed
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 17, 2024
@metacosm metacosm changed the title feat: context getSecondary resource is activation conidition aware feat: context getSecondary resource is activation condition aware Sep 18, 2024
@csviri csviri marked this pull request as ready for review September 18, 2024 08:43
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 18, 2024
@csviri csviri self-assigned this Sep 18, 2024
@csviri
feat: context getSecondary resource is activation conidition aware
3ae6fdc 
Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
@csviri
unit test
6ae450d 
Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
@csviri
add integration test
2f9190f 
Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
@csviri csviri force-pushed the secondary-activation branch from 5dc5f4b to 2f9190f Compare September 20, 2024 07:09
metacosm
metacosm approved these changes Sep 22, 2024
View reviewed changes
Copy link
Collaborator

@metacosm metacosm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@csviri csviri merged commit 8039ef0 into next Sep 23, 2024
20 checks passed
@csviri csviri deleted the secondary-activation branch September 23, 2024 06:48
metacosm pushed a commit that referenced this pull request Oct 10, 2024
@csviri @metacosm
feat: context getSecondary resource is activation condition aware (#2532
1b7b2d5 
)


Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
metacosm pushed a commit that referenced this pull request Nov 5, 2024
@csviri @metacosm
feat: context getSecondary resource is activation condition aware (#2532
d2976b0 
)


Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
metacosm pushed a commit that referenced this pull request Nov 6, 2024
@csviri @metacosm
feat: context getSecondary resource is activation condition aware (#2532
f5677fe 
)


Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
csviri added a commit that referenced this pull request Nov 13, 2024
@csviri
feat: context getSecondary resource is activation condition aware (#2532
76163c8 
)


Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
metacosm pushed a commit that referenced this pull request Nov 19, 2024
@csviri @metacosm
feat: context getSecondary resource is activation condition aware (#2532
569cea9 
)


Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
metacosm pushed a commit that referenced this pull request Nov 20, 2024
@csviri @metacosm
feat: context getSecondary resource is activation condition aware (#2532
7b9fe92 
)


Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
metacosm pushed a commit that referenced this pull request Nov 27, 2024
@csviri @metacosm
feat: context getSecondary resource is activation condition aware (#2532
4eb1265 
)


Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
This was referenced Dec 3, 2024
Merged
Closed
csviri added a commit that referenced this pull request Dec 6, 2024
@csviri
feat: context getSecondary resource is activation condition aware (#2532
e289c98 
)


Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@metacosm metacosm metacosm approved these changes

@adam-sandor adam-sandor Awaiting requested review from adam-sandor

Assignees

@csviri csviri

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Context.getSecondaryResource(A.class) should return Optional.empty when activationCondition not met
3 participants
@csviri @metacosm @openshift-merge-robot