feat: @ControllerConfiguration annotation is optional #2412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
the
do-not-merge/work-in-progress
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
openshift-merge-robot
added
the
needs-rebase
csviri
force-pushed
the
optional-controller-config
branch
from
7f552c9 to
613e61a
Compare
openshift-merge-robot
removed
the
needs-rebase
csviri
force-pushed
the
optional-controller-config
branch
2 times, most recently
from
6916ca4 to
2804b62
Compare
openshift-merge-robot
added
the
needs-rebase
Signed-off-by: Attila Mészáros <csviri@gmail.com>
Signed-off-by: Attila Mészáros <csviri@gmail.com>
Signed-off-by: Attila Mészáros <csviri@gmail.com>
csviri
force-pushed
the
optional-controller-config
branch
from
2804b62 to
0b78047
Compare
openshift-merge-robot
removed
the
needs-rebase
Signed-off-by: Attila Mészáros <csviri@gmail.com>
metacosm
reviewed
Jun 21, 2024
| try { | ||
| if (controllerConfiguration == null) { | ||
| return (T) io.javaoperatorsdk.operator.api.reconciler.ControllerConfiguration.class | ||
| .getDeclaredMethod(defaultMethodName).getDefaultValue(); |
There was a problem hiding this comment.
This is a little dangerous since it references method names directly and they can change… That said that approach is more or less used in QOSDK as well so 🤷🏼
metacosm
approved these changes
Jun 21, 2024
metacosm
added a commit
that referenced
this pull request
Jul 8, 2024
Signed-off-by: Attila Mészáros <csviri@gmail.com> Co-authored-by: Chris Laprun <claprun@redhat.com>
metacosm
added a commit
that referenced
this pull request
Jul 9, 2024
Signed-off-by: Attila Mészáros <csviri@gmail.com> Co-authored-by: Chris Laprun <claprun@redhat.com>
metacosm
added a commit
that referenced
this pull request
Jul 12, 2024
Signed-off-by: Attila Mészáros <csviri@gmail.com> Co-authored-by: Chris Laprun <claprun@redhat.com>
csviri
added a commit
that referenced
this pull request
Aug 8, 2024
Signed-off-by: Attila Mészáros <csviri@gmail.com> Co-authored-by: Chris Laprun <claprun@redhat.com>
csviri
added a commit
that referenced
this pull request
Aug 15, 2024
Signed-off-by: Attila Mészáros <csviri@gmail.com> Co-authored-by: Chris Laprun <claprun@redhat.com>
metacosm
added a commit
that referenced
this pull request
Aug 29, 2024
Signed-off-by: Attila Mészáros <csviri@gmail.com> Co-authored-by: Chris Laprun <claprun@redhat.com>
csviri
added a commit
that referenced
this pull request
Sep 20, 2024
Signed-off-by: Attila Mészáros <csviri@gmail.com> Co-authored-by: Chris Laprun <claprun@redhat.com>
metacosm
added a commit
that referenced
this pull request
Oct 10, 2024
Signed-off-by: Attila Mészáros <csviri@gmail.com> Co-authored-by: Chris Laprun <claprun@redhat.com>
metacosm
added a commit
that referenced
this pull request
Nov 5, 2024
Signed-off-by: Attila Mészáros <csviri@gmail.com> Co-authored-by: Chris Laprun <claprun@redhat.com>
metacosm
added a commit
that referenced
this pull request
Nov 6, 2024
Signed-off-by: Attila Mészáros <csviri@gmail.com> Co-authored-by: Chris Laprun <claprun@redhat.com>
csviri
added a commit
that referenced
this pull request
Nov 13, 2024
Signed-off-by: Attila Mészáros <csviri@gmail.com> Co-authored-by: Chris Laprun <claprun@redhat.com>
metacosm
added a commit
that referenced
this pull request
Nov 19, 2024
Signed-off-by: Attila Mészáros <csviri@gmail.com> Co-authored-by: Chris Laprun <claprun@redhat.com>
metacosm
added a commit
that referenced
this pull request
Nov 20, 2024
Signed-off-by: Attila Mészáros <csviri@gmail.com> Co-authored-by: Chris Laprun <claprun@redhat.com>
metacosm
added a commit
that referenced
this pull request
Nov 27, 2024
Signed-off-by: Attila Mészáros <csviri@gmail.com> Co-authored-by: Chris Laprun <claprun@redhat.com>
This was referenced Dec 3, 2024
csviri
added a commit
that referenced
this pull request
Dec 6, 2024
Signed-off-by: Attila Mészáros <csviri@gmail.com> Co-authored-by: Chris Laprun <claprun@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.