feat: Make @Configured, @GradualRetry and @RateLimited Inherited (#2091)

[BramMeerten]

Noticed that for @Configured there already was a test with an annotation on a superclass (BaseConfigurationServiceTest::configuringFromCustomAnnotationsShouldWork). Custom code was written in DependentResourceConfigurationResolver.java to make this work. But seems unneeded when @Configured is inherited.

[BramMeerten]

Not sure why the check_format_and_unit_tests step is failing, I imported the google code style into Intellij as the contributing guidelines requested and formatted using Intellij.
I also tried to run mvn -f operator-framework net.revelc.code.formatter:formatter-maven-plugin:2.23.0:format as the output of the failed build step suggests, but that reformats the code to 4 spaces indentation (among other things)..

edit: the links in contributing doc to code style do not work

[csviri]

@BramMeerten running just mvn clean install should fix the formatting. Would it be possible to target next branch, instead of main?

[BramMeerten]

@csviri Updated it, noticed one test is failing registerConverterShouldWork. Don't have time for it today. Will try to look tomorrow.

[metacosm]

I don't think this should have been closed, @csviri.

[csviri]

Sorry this was a mistake.

[csviri]

Ahh, I know what happened, merged the next into main, therefor the next branch branch was deleted

[metacosm]

Ahh, I know what happened, merged the next into main, therefor the next branch branch was deleted

Yeah, that's what I thought as well, just wanted to make sure you were aware of it :)

[csviri]

@BramMeerten do you plan to proceed with this issue?

[BramMeerten]

@csviri Yes, sorry had a very busy week. I probably won't have time until the weekend

[csviri]

@csviri Yes, sorry had a very busy week. I probably won't have time until the weekend

@BramMeerten sure, no hury, thank you!

[BramMeerten]

@csviri this is ready now to be reviewed.

In my first version I made @Configured inherited as well, but I had to revert that because it was a breaking change. It's hard to explain why it's breaking, it's easiest to explain if you run this test: DependentResourceConfigurationResolverTest::registerConverterShouldWork

Step 1

First a converter is registered for KubernetesDependentResource

DependentResourceConfigurationResolver.registerConverter(KubernetesDependentResource.class, overriddenConverter);

Step 2

Configuration is extracted from @Configured for ServiceDep (extends from KubernetesDependentResource)

DependentResourceConfigurationResolver.extractConfigurationFromConfigured(ServiceDep.class, cfg);

Step 2.a
Find Configured annotation for ServiceDep (DependentResourceConfigurationResolver::getConfigured).

• In the @inherited version it will find the annotation immediately in the first iteration.
• In the non-@Inherited version it will find the same annotation, but it takes two iterations. The annotation is fetched from the superclass (KubernetesDependentResource).

Step 2.b
Return Configured in a ConfiguredClassPair.

• In the @Inherited version the annotatedClass param is ServiceDep because it's found in the first iteration.
• In the non-@Inherited version the param is KubernetesDependentResource because the annotation was found on the superclass.

Step 2.c
Use the ConfiguredClassPair::annotatedClass to look for existing converters.

• In the @Inherited version none will be found because there is no converter for ServiceDep. The overriddenConverter from step 1 was configured for KubernetesDependentResource.
• In the non-@Inherited version the overriddenConverter from step 1 is found.

[BramMeerten]

One check (integration_tests (11, v1.25.14) failed because "The operation was canceled." but tests were successful

The other check (sample_operators_tests) works locally on my laptop and I don't think my changes impact these tests. So not sure what is happening.

[csviri]

Hi Bram, the failing tests are currently under investigation, not relevant for your PR.
Will try to review it asap just currently AFK mostly for next 2 weeks, but probably will be able find some time. Thank you!