tweak NewSdkCollectionFromEnv and fix the http-client example #662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ziti/collection.go
Outdated
| @@ -62,7 +62,7 @@ func NewSdkCollection() *CtxCollection { | |||
|
|
|||
| // NewSdkCollectionFromEnv will create an empty CtxCollection and then attempt to populate it from configuration files | |||
| // provided in a semicolon separate list of file paths retrieved from an environment variable. | |||
| func NewSdkCollectionFromEnv(envVariable string) *CtxCollection { | |||
| func NewSdkCollectionFromEnv(envVariable string, configTypes []string) *CtxCollection { | |||
There was a problem hiding this comment.
This is an externally consumed function, this would be a major bump if left as as.
You chould make it take an an optional number of strings, which can be 0 or more.
NewSdkCollectionFromEnv(envVariable string, configTypes ...string)
Which allows 0 or more config types to be specified. You still access configTypes like a slice.
This allow old calls NewSdkCollection("myEnv") and NewSdkCollection("myEnv", "config1", "config2") or using an exploded slice NewSdkCollection("myEnv", myConfigs...) where myConfig := []string{"confi1","config2"}
There was a problem hiding this comment.
that is a grand idea. done
… if none are passed
plorenz
approved these changes
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.