Fixed suggestions for a single-word-followed-by-space query #953
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... by taking advantage of the EXPECT_SUGGESTION_RESULTS() macro that was introduced a bit late in the history of that unit test.
The test keeps passing.
A single-word query followed by a space character is mishandled by the suggestions query parser: - the query 'the' is parsed as Query((((WILDCARD SYNONYM the OR Zthe@1) OR the) OR (0posanchor PHRASE 2 the))) - whereas the query 'the ' is parsed as Query(WILDCARD SYNONYM the )
I wonder why I used Xapian::Query::get_num_subqueries() instead of Xapian::Query::empty() back in #765.
mgautierfr
approved these changes
Feb 14, 2025
| @@ -143,7 +143,7 @@ Xapian::Query SuggestionDataBase::parseQuery(const std::string& query) | |||
| m_queryParser.set_stemming_strategy(Xapian::QueryParser::STEM_SOME); | |||
| xquery = m_queryParser.parse_query(query, flags); | |||
|
|
|||
| if ( !query.empty() && xquery.get_num_subqueries() == 0 ) { | |||
| if ( !query.empty() && xquery.empty() ) { | |||
There was a problem hiding this comment.
Well, I was not enough conscientious on the review too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes kiwix/kiwix-desktop#1345