Skip to content

Commit

Permalink
[XLA:GPU] Add check that computation is found in TritonFilecheckTest.
Browse files Browse the repository at this point in the history
TritonFileCheckTest::CreateTritonIrAndFilecheck fails with an obscure segmentation fault in TritonFusionAnalysis::Execute if an incorrect name for the triton function is passed in. This makes it seem like the issue is around tiling analysis when it is just a test typo. This change adds a ret_check to clarify that the failure is from the call to GetComputationWithName.
PiperOrigin-RevId: 605007087
  • Loading branch information
jvstokes authored and copybara-github committed Feb 7, 2024
1 parent 6ef18ff commit 549e95a
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions xla/service/gpu/ir_emitter_triton_test.cc
Original file line number Diff line number Diff line change
Expand Up @@ -121,6 +121,7 @@ absl::StatusOr<bool> TritonFilecheckTest::CreateTritonIrAndFileCheck(

auto* computation =
verified_module->GetComputationWithName(triton_fusion_name);
TF_RET_CHECK(computation != nullptr);
TF_ASSIGN_OR_RETURN(auto analysis,
TritonFusionAnalysis::Execute(*computation));

Expand Down

0 comments on commit 549e95a

Please sign in to comment.