Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use free function instead of method for dyn_cast_or_null #2280

Merged

Conversation

mlevesquedion
Copy link
Contributor

The method variant is deprecated.

Copy link
Member

@ghpvnist ghpvnist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change lgtm. I think we have other uses of deprecated casts. Are you tracking them by any chance?

@mlevesquedion
Copy link
Contributor Author

This change lgtm. I think we have other uses of deprecated casts. Are you tracking them by any chance?

I believe this should be the last one, unless we add more. I grepped the codebase and didn't find anything else.

(This one was added after I removed most occurrences in #2180. Another one was removed in #2260.)

@mlevesquedion mlevesquedion merged commit c0132de into openxla:main May 2, 2024
10 checks passed
@mlevesquedion mlevesquedion deleted the update-deprecated-dyn-cast-or-null branch May 2, 2024 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants