Include output shape in shape mismatch error message #2264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As discussed in openxla#2231 (comment), this will likely help with debugging shape mismatches.
abhigunj
approved these changes
Apr 29, 2024
ghpvnist
reviewed
Apr 29, 2024
ghpvnist
approved these changes
Apr 29, 2024
mlevesquedion
pushed a commit
that referenced
this pull request
May 3, 2024
And use the helper to verify shape operands in DynamicBroadcastInDim, DynamicIota and DynamicReshape. Also, reorganize the isCompatibleForHloTypeInference logic a little bit to avoid duplication. This is a follow-up/generalization of #2264.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in
#2231 (comment), this will likely help with debugging shape mismatches.