Fix ConditionalSpeculatability implementation for DynamicReshape #2261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Both the input and the shape must be fully known statically. Whether the output is dynamic or not does not matter. Indeed, consider e.g.: ``` func.func @foo(%arg0: tensor<?x?xf64>) { %constant_shape = stablehlo.constant dense<[2, 3]> : tensor<2xi32> %0 = stablehlo.dynamic_reshape %arg0, %constant_shape : (tensor<?x?xf64>, tensor<2xi32>) -> tensor<?x?xf64> return } ``` The input is dynamic, so it could turn out to have e.g. 10 elements instead of the expected 6. Similarly, if the shape is unknown: ``` func.func @foo(%arg0: tensor<2x3xf64>, %unknown_shape: tensor<2xi32>) { %0 = stablehlo.dynamic_reshape %arg0, %unknown_shape : (tensor<2x3xf64>, tensor<2xi32>) -> tensor<?x?xf64> return } ``` Again, the shape could turn out to be e.g. `[2, 5]` at runtime and so the reshape's behavior would be undefined.
sdasgup3
approved these changes
Apr 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both the input and the shape must be fully known statically. Whether the output is dynamic or not does not matter.
Indeed, consider e.g.:
The input is dynamic, so it could turn out to have e.g. 10 elements instead of the expected 6. Similarly, if the shape is unknown:
Again, the shape could turn out to be e.g.
[2, 5]at runtime and so the reshape's behavior would be undefined.