Implement ConditionallySpeculatable for remaining dynamic ops #2242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Converting to draft while I revisit the shared implementation for ops that have shape operands. |
mlevesquedion
force-pushed
the
dyn-cs
branch
3 times, most recently
from
40d2db2 to
5c4a2de
Compare
|
This is once again ready for review. |
Included ops: - DynamicPad - RealDynamicSlice - DynamicConv - DynamicGather I refactored the logic to check speculatability for shaped ops to enable reuse and allow ops with more than one shape-related operand to be checked. This should be the last change adding new speculatability implementations. All the other ops are either done, pure, or deprecated. I will confirm this shortly by reviewing the entire opset and making sure everything is covered (I have been tracking progress in a personal document).
|
There were some merge conflicts. Those are fixed now. |
sdasgup3
reviewed
May 1, 2024
sdasgup3
approved these changes
May 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Included ops:
I refactored the logic to check speculatability for shaped ops to enable
reuse and allow ops with more than one shape-related operand to be
checked.
This should be the last change adding new speculatability
implementations. All the other ops are either done, pure, or
deprecated. I will confirm this shortly by reviewing the entire opset
and making sure everything is covered (I have been tracking progress in
a personal document).