-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix TOSA related breakages #2751
Comments
Other than the usual integration, this PR also addresses the followings: 1. Disables certain build and tests for #2751. In stablehlo/conversions/tosa/transforms/CMakeLists.txt, just commenting the problematic files is not enough because ``` LLVM's build system enforces that all source files are added to a build target ``` Hence we added add `PARTIAL_SOURCES_INTENDED` to the target specification, though it is discouraged. 1. Fixes `build_tools/integrate/llvm_bump_revision.sh` to account for unset value of `$1` as enforced by `set -o nounset`
I already have a fix for the compile errors, and adjusted the tests legalize_quant_ops_to_tosa_rescale.mlir and legalize_tosa_rescale_to_stablehlo.mlir |
I pushed a PR: #2756 once the stablehlo llvm has been updated to include that, I will test and re-enable tosa legalization in stablehlo |
Thanks again for your fixes!
#2758 is an attempt to test all the affected tests (including nullary.mlir,binary.mlir, and ternay.mlir) after updating the llvm. This seems working fine and hence closing the ticket. Please feel free to re-open in case there is more to it. |
Hi @Tai78641
The recent TOSA dialect changes introduced by https://github.com/llvm/llvm-project/pull/129720 have caused breakages, for example:
The PR is an attempt to address some of these issues, but it appears that the problem is more involving than we initially anticipated. Do you mind helping us updating the
StablehloQuantLegalizeToTosaRescale.cpp
andTosaRescaleLegalizeToStablehlo.cpp
passes to accommodate these recent changes.The text was updated successfully, but these errors were encountered: