Remove comments saying dynamic result means speculatable

openxla · May 1, 2024 · 8fec76b · 8fec76b
1 parent 7a19019
commit 8fec76b
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/stablehlo/dialect/Base.h b/stablehlo/dialect/Base.h
@@ -257,8 +257,8 @@ void writeEnumAttribute(EnumTypeAttr val, DialectBytecodeWriter &writer) {
 
 // Determines the speculatability for a shaped operation `op` with `shapeCount`
 // shape operands. The last `count` operands are assumed to be shape operands.
-// To be speculatable, such an op must either have a fully dynamic result type
-// or have only static inputs and constant shape operands.
+// To be speculatable, such an op must have only static inputs and constant
+// shape operands.
 mlir::Speculation::Speculatability getShapedSpeculatability(Operation *op,
                                                             int64_t shapeCount);
 

diff --git a/stablehlo/dialect/Base.td b/stablehlo/dialect/Base.td
@@ -372,8 +372,8 @@ def HLO_SpeculatableIfAllInputsStaticAndShapeConstantImplTrait
   : HLO_NativeOpTrait<"SpeculatableIfAllInputsStaticAndShapeConstantImplTrait">;
 
 // This trait is the same as HLO_SpeculatableIfAllInputsStatic, but for ops that
-// take a shape as their last operand. Such ops are speculatable if either the
-// output is dynamic or all inputs are static and the shape is constant.
+// take a shape as their last operand. Such ops are speculatable if all inputs
+// are static and the shape is constant.
 def HLO_SpeculatableIfAllInputsStaticAndShapeConstant : TraitList<[
     ConditionallySpeculatable, HLO_SpeculatableIfAllInputsStaticAndShapeConstantImplTrait]>;