From 75d667c7099486259a014849cdc7c44c9f847d85 Mon Sep 17 00:00:00 2001 From: Tom Natan Date: Mon, 10 Feb 2025 02:13:35 -0800 Subject: [PATCH] test structured bindings PiperOrigin-RevId: 725127187 --- .../dialect/sdy/transforms/propagation/basic_propagation.cc | 6 +----- .../sdy/transforms/propagation/debugging/source_sharding.cc | 2 +- 2 files changed, 2 insertions(+), 6 deletions(-) diff --git a/shardy/dialect/sdy/transforms/propagation/basic_propagation.cc b/shardy/dialect/sdy/transforms/propagation/basic_propagation.cc index e375bce..e967c14 100644 --- a/shardy/dialect/sdy/transforms/propagation/basic_propagation.cc +++ b/shardy/dialect/sdy/transforms/propagation/basic_propagation.cc @@ -614,11 +614,7 @@ LogicalResult BasicPropagationPassImpl::propagate( conservativePropagation, shardingGroupMap); // We only need a single iteration (and another to confirm convergence), since // we make sure ops whose sharding changes are added back to the worklist. - GreedyRewriteConfig config; - config.useTopDownTraversal = true; - config.enableRegionSimplification = mlir::GreedySimplifyRegionLevel::Disabled; - config.fold = false; - config.cseConstants = false; + GreedyRewriteConfig config{.useTopDownTraversal = true}; if (failed(applyPatternsGreedily(moduleOp, std::move(patterns), config))) { // We should always converge in 2 iterations, if we don't, something is // wrong. diff --git a/shardy/dialect/sdy/transforms/propagation/debugging/source_sharding.cc b/shardy/dialect/sdy/transforms/propagation/debugging/source_sharding.cc index e45a6b2..49784eb 100644 --- a/shardy/dialect/sdy/transforms/propagation/debugging/source_sharding.cc +++ b/shardy/dialect/sdy/transforms/propagation/debugging/source_sharding.cc @@ -317,7 +317,7 @@ void saveShardingOriginsOnModule( builder.getDictionaryAttr(entries)); } TypeSwitch(owningOp) - .Case([&, value = value](func::FuncOp funcOp) { + .Case([&](func::FuncOp funcOp) { funcOp.setArgAttr(cast(value).getArgNumber(), kShardingOriginsAttr, builder.getDictionaryAttr(entries));