Skip to content

Commit

Permalink
test structured bindings
Browse files Browse the repository at this point in the history
PiperOrigin-RevId: 725127187
  • Loading branch information
tomnatan30 authored and copybara-github committed Feb 10, 2025
1 parent 2cef0d9 commit 75d667c
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 6 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -614,11 +614,7 @@ LogicalResult BasicPropagationPassImpl::propagate(
conservativePropagation, shardingGroupMap);
// We only need a single iteration (and another to confirm convergence), since
// we make sure ops whose sharding changes are added back to the worklist.
GreedyRewriteConfig config;
config.useTopDownTraversal = true;
config.enableRegionSimplification = mlir::GreedySimplifyRegionLevel::Disabled;
config.fold = false;
config.cseConstants = false;
GreedyRewriteConfig config{.useTopDownTraversal = true};
if (failed(applyPatternsGreedily(moduleOp, std::move(patterns), config))) {
// We should always converge in 2 iterations, if we don't, something is
// wrong.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -317,7 +317,7 @@ void saveShardingOriginsOnModule(
builder.getDictionaryAttr(entries));
}
TypeSwitch<Operation*, void>(owningOp)
.Case<func::FuncOp>([&, value = value](func::FuncOp funcOp) {
.Case<func::FuncOp>([&](func::FuncOp funcOp) {
funcOp.setArgAttr(cast<BlockArgument>(value).getArgNumber(),
kShardingOriginsAttr,
builder.getDictionaryAttr(entries));
Expand Down

0 comments on commit 75d667c

Please sign in to comment.